Review main Merged

81921[BUGFIX] Use correct `Configuration` ignore in namespace integrity check

Stefan Bürk CR +2 V +2 Easy +7 −5 updated 11/23/23, 15:29

Commit message

The php namespace integrity check uses a symfony
finder to determine which files should be checked.
The used pattern to ignore extension configuration
folder `Configuration` excluded every file,  which
has `Configuration` in the path or filename.

This change avoids using the nifty magic `exclude()`
finder method and replace it with a more reliable
`notPath()` configuration.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Stefan Bürk uploaded patch set 1 11/23/23, 12:38

  2. core-ci voted on patch set 1 V -1 11/23/23, 12:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49676

  3. Christian Kuhn uploaded patch set 2 V -1 11/23/23, 13:30

  4. core-ci voted on patch set 2 V +1 11/23/23, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49686

  5. Garvin Hicking voted on patch set 2 CR +1 V +1 11/23/23, 14:11

  6. Christian Kuhn voted on patch set 2 CR +1 V +1 11/23/23, 15:01

  7. Stefan Bürk voted on patch set 2 CR +2 V +2 11/23/23, 15:07

  8. Christian Kuhn voted on patch set 2 CR +2 V +2 11/23/23, 15:28

  9. Christian Kuhn merged patch set 3 11/23/23, 15:29