Review 12.4 Merged

81927[TASK] Automatically remove containers in runTests.sh

Christian Kuhn CR +2 V +2 Normal +26 −31 updated 11/23/23, 17:24

Commit message

Removing all containers will remove their dangling volumes
automatically and we can drop the manual cleanup.

Parameters have been applied via:
  sed -i '/CONTAINER_COMMON_PARAMS/!s/\${CONTAINER_BIN} run/& --rm/' \
    Build/Scripts/runTests.sh

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Christian Kuhn uploaded patch set 1 11/23/23, 15:24

  2. core-ci voted on patch set 1 V +1 11/23/23, 15:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49713

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 11/23/23, 17:24

  4. Christian Kuhn merged patch set 2 11/23/23, 17:24