Review main Merged

81929[BUGFIX] Ensure uuid value is unique on copy + publish commands

Oli Bartsch CR +2 V +2 Hard +751 −73 updated 03/25/25, 15:34

Commit message

This change aims to fix the UUID behavior of
TCA type=uuid.

1. When a new record with field type=uuid is created,
  a UUID is created in DataHandler (and FormEngine in advance)

2. When copying/localizing a record, a new UUID is
  created at any times.

3. When moving a record, the UUID is kept the same.

4. When publishing a versioned record, the UUID field
   is skipped when interchanging the arrays.

5. When a UUID field has l10n_mode=exclude, then the
   translation contains the same value as the default
   language record.

Additionally, the FormEngine data provider
only generates a uuid value, in case the field
is marked as "required", which is the default.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 17

Review log 3249

Show 1524 earlier messages
  1. Oli Bartsch uploaded patch set 1 11/23/23, 15:30

  2. core-ci voted on patch set 1 V +1 11/23/23, 15:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49715

  3. Oli Bartsch uploaded patch set 2 V +1 11/23/23, 15:44

  4. core-ci voted on patch set 2 V -1 11/23/23, 15:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49717

  5. Oli Bartsch uploaded patch set 3 V -1 11/23/23, 15:51

  6. core-ci voted on patch set 3 V +1 11/23/23, 15:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49718

  7. Jochen Roth voted on patch set 3 CR +1 V +1 11/23/23, 15:57

  8. Oli Bartsch uploaded patch set 4 CR +1 V +1 11/23/23, 16:06

  9. Jochen Roth voted on patch set 4 CR +1 V +1 11/23/23, 16:09

  10. core-ci voted on patch set 4 V +1 11/23/23, 16:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49755

  11. Christian Kuhn commented on patch set 4 CR -1 11/23/23, 21:35

    let's have the factory non-static to allow DI of it, and let's please have a basic coverage for: new + copy in live WS, change + new + copy in ws.
  12. Oli Bartsch uploaded patch set 5 CR +1 V +1 11/24/23, 10:19

  13. core-ci voted on patch set 5 V -1 11/24/23, 10:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49867

  14. Oli Bartsch uploaded patch set 6 V -1 11/24/23, 18:06

  15. core-ci voted on patch set 6 V +1 11/24/23, 18:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49902

  16. Georg Ringer uploaded patch set 7 V +1 06/07/24, 13:00

  17. core-ci voted on patch set 7 V -1 06/07/24, 13:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58878

  18. Benni Mack updated the commit message in patch set 8 V -1 10/18/24, 13:31

  19. core-ci voted on patch set 8 V -1 10/18/24, 22:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67984

  20. Benni Mack marked it work in progress 03/22/25, 12:33

  21. Benni Mack uploaded patch set 9 V -1 03/24/25, 15:36

  22. core-ci voted on patch set 9 V -1 03/24/25, 15:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76150

  23. Benni Mack uploaded patch set 10 V -1 03/24/25, 17:01

  24. Benni Mack marked it ready for review 03/24/25, 17:09

  1. core-ci voted on patch set 10 V -1 03/24/25, 17:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76156

  2. Benni Mack uploaded patch set 11 V -1 03/24/25, 17:16

  3. Benni Mack commented on patch set 11 CR +1 V +1 03/24/25, 17:16

    Reply

    Done
  4. core-ci voted on patch set 11 V +1 03/24/25, 17:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76158

  5. Oli Bartsch uploaded patch set 12 CR +1 V +1 03/24/25, 18:07

  6. Oli Bartsch uploaded patch set 13 03/24/25, 18:08

  7. core-ci voted on patch set 12 V -1 03/24/25, 18:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76162

  8. core-ci voted on patch set 13 V -1 03/24/25, 18:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76163

  9. Oli Bartsch uploaded patch set 14 V -1 03/24/25, 20:31

  10. core-ci voted on patch set 14 V -1 03/24/25, 20:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76176

  11. Oli Bartsch uploaded patch set 15 V -1 03/24/25, 20:42

  12. core-ci voted on patch set 15 V +1 03/24/25, 20:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76179

  13. Oli Bartsch voted on patch set 15 CR +1 V +1 03/24/25, 21:25

  14. Christian Kuhn voted on patch set 15 CR -1 03/25/25, 14:01

  15. Christian Kuhn commented on patch set 15 03/25/25, 14:34

    DataHandler.php:3974

    this should be $conf['version']
  16. Christian Kuhn uploaded patch set 16 CR +1 V +1 03/25/25, 14:45

  17. Christian Kuhn commented on patch set 16 03/25/25, 14:45

    DataHandler.php:3974 Reply

    Done
  18. Christian Kuhn uploaded patch set 17 03/25/25, 14:52

  19. core-ci voted on patch set 16 V +1 03/25/25, 14:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76265

  20. core-ci voted on patch set 17 V +1 03/25/25, 15:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76266

  21. Benni Mack voted on patch set 17 CR +1 V +1 03/25/25, 15:01

  22. Christian Kuhn voted on patch set 17 CR +1 V +1 03/25/25, 15:08

  23. Oli Bartsch voted on patch set 17 CR +1 V +1 03/25/25, 15:19

  24. Christian Kuhn voted on patch set 17 CR +2 V +2 03/25/25, 15:21

  25. Christian Kuhn merged patch set 18 03/25/25, 15:34