Review main Merged

81939[TASK] Remove usage of three deprecated `AbstractPlatform` methods

Stefan Bürk CR +2 V +2 Easy +8 −3 updated 11/23/23, 18:49

Commit message

Doctrine DBAL depreated a couple of `AbstractPlatform methods [1]
producing SQL fragments which does not vary between platforms.
Following methods from the deprecated list are in use:

* `AbstractPlatform->getSqlCommentStartString()`
* `AbstractPlatform->getSqlCommentEndString()`
* `AbstractPlatform->getCountExpression()`

This change replace the occurances with the plain values.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2