Review main Merged

81940[TASK] Outsource common multi record actions template part

Oli Bartsch CR +2 V +2 Hard +179 −121 updated 11/24/23, 09:49

Commit message

This follows #100227, which outsourced common
multi record selection actions into dedicated
JS components to be reusable in the different
backend modules.

This is now also done for the template part,
which is therefore outsourced into a partial,
coupled with a dedicated new Action object
component.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 8

Review log 1012

  1. Oli Bartsch uploaded patch set 1 11/23/23, 18:55

  2. core-ci voted on patch set 1 V +1 11/23/23, 19:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49813

  3. Jochen Roth voted on patch set 1 CR +1 V +1 11/23/23, 19:18

  4. Benni Mack voted on patch set 1 CR +1 V +1 11/23/23, 20:51

  5. Oli Bartsch uploaded patch set 2 CR +1 V +1 11/23/23, 21:08

  6. core-ci voted on patch set 2 V +1 11/23/23, 21:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49821

  7. Jochen Roth voted on patch set 2 CR +1 V +1 11/23/23, 21:38

  8. Christian Kuhn voted on patch set 2 CR +1 V +1 11/23/23, 21:38

  9. Simon Schaufelberger commented on patch set 2 11/23/23, 21:52

    Overview.html:61

    to actually format it a comment, a HTML comment would be nice to wrap around the text
  10. Oli Bartsch commented on patch set 2 CR +2 V +2 11/23/23, 23:17

    Overview.html:61 Reply

    what do you mean with “format it a comment”? Do you mean to get IDEs to recognize it as comment? IMO using f:comment is fine in this case.
  11. Oli Bartsch merged patch set 3 11/23/23, 23:17

  12. Simon Schaufelberger commented on patch set 3 11/24/23, 09:49

    Overview.html:61 Reply Unresolved

    yes, exactly. just wrap a <!-- text --> around.