Review main Merged

81942[TASK] Use `Connection::PARAM_STR` instead of null in `BulkInsertQuery`

Stefan Bürk CR +2 V +2 Easy +16 −18 updated 11/23/23, 21:10

Commit message

Doctrine DBAL deprecated the support for integer type values based
on the php-pdo `\PDO::PARAM_*` constants as preparation to replace
them with native php enums `ParameterType|ArrayParameterType` with
the next major version.

Due to this fact, it's not possible to have an null value for an
type to fallback to `ParameterType::PARAM_STR`.

This change sets for undefined types (null) the `Connection::PARAM_STR`
to prepare for `doctrine/dbal 4.x` upgrade.

Note:	With the `doctrine/dbal 4.x` the `Connection::PARAM_*`
	constants will be replaced with the `ParameterType`
	and `ArrayParameterType` enums.

[1] https://github.com/doctrine/dbal/blob/3.7.x/UPGRADE.md#bc-break-the-pdo-symbols-are-no-longer-part-of-the-dbal-api
[2] https://github.com/doctrine/dbal/blob/4.0.x/UPGRADE.md#bc-break-removed-support-for-using-null-as-prepared-statement-parameter-type

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Andreas Nedbal +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Andreas Nedbal +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Stefan Bürk uploaded patch set 1 11/23/23, 19:26

  2. Stefan Bürk updated the commit message in patch set 2 11/23/23, 19:27

  3. core-ci voted on patch set 1 V +1 11/23/23, 19:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49817

  4. core-ci voted on patch set 2 V +1 11/23/23, 19:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49818

  5. Andreas Nedbal voted on patch set 2 CR +1 V +1 11/23/23, 19:45

  6. Benni Mack voted on patch set 2 CR +1 V +1 11/23/23, 20:43

  7. Stefan Bürk voted on patch set 2 CR +2 V +2 11/23/23, 21:10

  8. Stefan Bürk merged patch set 3 11/23/23, 21:10