81943[BUGFIX] Add aria-label to context menu buttons
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Jasmina Ließmann +1
- Garvin Hicking +1
- Michael Telgkamp +1
-
Verified V +2 Done
- Christian Kuhn +2
- Jasmina Ließmann +1
- Garvin Hicking +1
- Michael Telgkamp +1
- core-ci +1 CI
Issues 1
Files 21
- Build/Sources/TypeScript/backend/drag-uploader.ts+2 −1
- typo3/sysext/backend/Classes/Form/FormResultCompiler.php+1 −0
- typo3/sysext/backend/Resources/Private/Language/locallang_layout.xlf+0 −3
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/RecordDefault/Header.html+2 −1
- typo3/sysext/backend/Resources/Private/Templates/Page/NewPages.html+1 −0
- typo3/sysext/backend/Resources/Private/Templates/PageTsConfig/RecordsOverview.html+1 −0
- typo3/sysext/backend/Resources/Private/Templates/SiteConfiguration/Overview.html+2 −1
- typo3/sysext/backend/Resources/Public/JavaScript/drag-uploader.js+1 −1
- typo3/sysext/beuser/Resources/Private/Partials/BackendUser/PaginatedList.html+1 −0
- typo3/sysext/beuser/Resources/Private/Partials/BackendUserGroup/PaginatedList.html+1 −0
- typo3/sysext/beuser/Resources/Private/Partials/Compare/Information.html+5 −0
- typo3/sysext/beuser/Resources/Private/Partials/Filemount/PaginatedList.html+1 −0
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Compare.html+2 −1
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/List.html+1 −0
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Online.html+1 −0
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Show.html+1 −0
- typo3/sysext/beuser/Resources/Private/Templates/BackendUserGroup/List.html+1 −0
- typo3/sysext/filelist/Classes/Controller/FileListController.php+1 −0
- typo3/sysext/reactions/Resources/Private/Templates/Management/Overview.html+1 −0
- typo3/sysext/sys_note/Resources/Private/Templates/List.html+1 −0
Review log 3446
Show 1621 earlier messages
-
Christian Rath-Ulrich uploaded patch set 1 11/23/23, 20:52
-
core-ci voted on patch set 1 V +1 11/23/23, 20:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49820
-
Garvin Hicking voted on patch set 1 CR +1 V +1 11/29/23, 14:12
-
Michael Telgkamp commented on patch set 1 V -1 12/01/23, 06:21
locallang_core.xlf:1522I would prefer to have action texts in active form (Open instead of opens). Additionally, the general name is "context menu" without the "sensitive". So in this case "Open context menu" would be a better language string. -
Christian Rath-Ulrich uploaded patch set 2
CR +1V +112/06/23, 09:33 -
Christian Rath-Ulrich commented on patch set 1 12/06/23, 09:33
BackendUtility.php:1923Replydid you find the places where the icon transport that information? the places i found just blindly bind the icon viewhelperlocallang_core.xlf:1522Replydone -
core-ci voted on patch set 2 V +1 12/06/23, 09:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50405
-
Benjamin Kott commented on patch set 2 03/01/24, 07:25
locallang_core.xlf:1521please adapt the identifier to more closely match the function of this label. `labels.contextmenu.open` for example. -
Benjamin Kott commented on patch set 2 03/01/24, 09:53
BackendUtility.php:1923ReplyI double-checked with NVDA, I think we do not need to talk about the current state as it seems to be unusable. But with NVDA it only states that a context menu should be opened, as Michael also mentioned, it probably should also be a button. But can be done in another patch. While the result may not be perfect, it´s better than what we already have. You lose the context here, but it´s the same for all other edit links for example that work that way. Edit, anyways the aria label should not be added directly to the element, instead please move this to the attributes from self::getContextMenuAttributes. -
Willi Wehmeier uploaded patch set 3
V +103/04/24, 11:51 -
Willi Wehmeier commented on patch set 3 03/04/24, 11:55
BackendUtility.php:1923ReplyAdded the aria-label to the getContextMenuAttributes method.locallang_core.xlf:1521ReplyChanged the label to the suggested one. -
core-ci voted on patch set 3 V +1 03/04/24, 11:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53833
-
Oli Bartsch uploaded patch set 4
V +103/04/24, 14:05 -
Oli Bartsch voted on patch set 4 CR +1 V +1 03/04/24, 14:05
-
core-ci voted on patch set 4 V +1 03/04/24, 14:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53851
-
Andreas Kienast commented on patch set 4 CR -1 03/04/24, 14:13
There are more context menus opened via Fluid that lack the `aria-label` property. Are those left out on purpose? -
Oli Bartsch uploaded patch set 5
CR +1V +103/04/24, 14:28 -
Oli Bartsch commented on patch set 5 03/04/24, 14:29
Reply
Done -
core-ci voted on patch set 5 V +1 03/04/24, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53856
-
Garvin Hicking voted on patch set 5 CR +1 V +1 03/04/24, 14:39
-
Oli Bartsch commented on patch set 5 CR -1 03/04/24, 14:49
Found another place
-
Oli Bartsch uploaded patch set 6
CR +1V +103/04/24, 15:01 -
Oli Bartsch commented on patch set 6 CR +1 V +1 03/04/24, 15:02
Reply
Done -
core-ci voted on patch set 6 V +1 03/04/24, 15:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53867
-
Willi Wehmeier uploaded patch set 7
CR +1V +103/15/24, 07:26 -
core-ci voted on patch set 7 V -1 03/15/24, 07:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54563
-
Willi Wehmeier uploaded patch set 8
V -103/15/24, 08:04 -
core-ci voted on patch set 8 V +1 03/15/24, 08:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54564
-
Michael Telgkamp uploaded patch set 9
V +106/12/24, 09:01 -
Michael Telgkamp commented on patch set 9 CR +1 V +1 06/12/24, 09:03
Rebased patch and adjusted capitalization of identifiers. -
core-ci voted on patch set 9 V +1 06/12/24, 09:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59293
-
Michael Telgkamp updated the commit message in patch set 10
CR +1V +106/12/24, 09:08 -
Michael Telgkamp voted on patch set 10 CR +1 V +1 06/12/24, 09:09
-
core-ci voted on patch set 10 V +1 06/12/24, 09:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59295
-
Jasmina Ließmann commented on patch set 10 06/12/24, 09:26
BackendUtility.php:2054This looks duplicate with the content in row 2063-2065. -
Jasmina Ließmann uploaded patch set 11
CR +1V +106/12/24, 09:34 -
Jasmina Ließmann commented on patch set 11 06/12/24, 09:34
BackendUtility.php:2054ReplyDone -
Michael Telgkamp voted on patch set 11 CR +1 V +1 06/12/24, 09:37
-
Jasmina Ließmann uploaded patch set 12
CR +1V +106/12/24, 09:38 -
Michael Telgkamp voted on patch set 12 CR +1 V +1 06/12/24, 09:40
-
Jasmina Ließmann voted on patch set 12 CR +1 V +1 06/12/24, 09:42
-
core-ci voted on patch set 11 V +1 06/12/24, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59298
-
core-ci voted on patch set 12 V +1 06/12/24, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59300
-
Garvin Hicking voted on patch set 12 CR +1 V +1 06/12/24, 11:44
-
Christian Kuhn voted on patch set 12 CR +2 V +2 06/12/24, 15:50
-
Christian Kuhn merged patch set 13 06/12/24, 16:11
BackendUtility.php:1923