Review main Merged

81943[BUGFIX] Add aria-label to context menu buttons

Christian Rath-Ulrich CR +2 V +2 Easy +28 −8 updated 06/12/24, 16:11

Commit message

To improve accessibility, an aria-label is added to all context menu
buttons to allow assistive technologies to announce them correctly.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Garvin Hicking +1
    • Michael Telgkamp +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Garvin Hicking +1
    • Michael Telgkamp +1
    • core-ci +1 CI

Issues 1

Files 21

Show 1 more file

Review log 3446

Show 1621 earlier messages
  1. Christian Rath-Ulrich uploaded patch set 1 11/23/23, 20:52

  2. core-ci voted on patch set 1 V +1 11/23/23, 20:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49820

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 11/29/23, 14:12

  4. Michael Telgkamp commented on patch set 1 V -1 12/01/23, 06:21

    BackendUtility.php:1923

    When using an aria label on the surrounding element, text from $content will be overwritten. So in case the Icon itself has a description of the action, this description will not be available for assistive technologies any longer. An additional side node: the interactive element for opening a context menu is a button, not a link, but this should probably be fixed in another patch.

    locallang_core.xlf:1522

    I would prefer to have action texts in active form (Open instead of opens). Additionally, the general name is "context menu" without the "sensitive". So in this case "Open context menu" would be a better language string.
  5. Christian Rath-Ulrich uploaded patch set 2 CR +1 V +1 12/06/23, 09:33

  6. Christian Rath-Ulrich commented on patch set 1 12/06/23, 09:33

    BackendUtility.php:1923 Reply

    did you find the places where the icon transport that information? the places i found just blindly bind the icon viewhelper

    locallang_core.xlf:1522 Reply

    done
  7. core-ci voted on patch set 2 V +1 12/06/23, 09:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50405

  8. Benjamin Kott commented on patch set 2 03/01/24, 07:25

    locallang_core.xlf:1521

    please adapt the identifier to more closely match the function of this label. `labels.contextmenu.open` for example.
  9. Benjamin Kott commented on patch set 2 03/01/24, 09:53

    BackendUtility.php:1923 Reply

    I double-checked with NVDA, I think we do not need to talk about the current state as it seems to be unusable. But with NVDA it only states that a context menu should be opened, as Michael also mentioned, it probably should also be a button. But can be done in another patch. While the result may not be perfect, it´s better than what we already have. You lose the context here, but it´s the same for all other edit links for example that work that way. Edit, anyways the aria label should not be added directly to the element, instead please move this to the attributes from self::getContextMenuAttributes.
  10. Willi Wehmeier uploaded patch set 3 V +1 03/04/24, 11:51

  11. Willi Wehmeier commented on patch set 3 03/04/24, 11:55

    BackendUtility.php:1923 Reply

    Added the aria-label to the getContextMenuAttributes method.

    locallang_core.xlf:1521 Reply

    Changed the label to the suggested one.
  12. core-ci voted on patch set 3 V +1 03/04/24, 11:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53833

  13. Oli Bartsch uploaded patch set 4 V +1 03/04/24, 14:05

  14. Oli Bartsch voted on patch set 4 CR +1 V +1 03/04/24, 14:05

  15. core-ci voted on patch set 4 V +1 03/04/24, 14:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53851

  16. Andreas Kienast commented on patch set 4 CR -1 03/04/24, 14:13

    There are more context menus opened via Fluid that lack the `aria-label` property. Are those left out on purpose?
  17. Oli Bartsch uploaded patch set 5 CR +1 V +1 03/04/24, 14:28

  18. Oli Bartsch commented on patch set 5 03/04/24, 14:29

    Reply

    Done
  19. core-ci voted on patch set 5 V +1 03/04/24, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53856

  20. Garvin Hicking voted on patch set 5 CR +1 V +1 03/04/24, 14:39

  21. Oli Bartsch commented on patch set 5 CR -1 03/04/24, 14:49

    Found another place
  1. Oli Bartsch uploaded patch set 6 CR +1 V +1 03/04/24, 15:01

  2. Oli Bartsch commented on patch set 6 CR +1 V +1 03/04/24, 15:02

    Reply

    Done
  3. core-ci voted on patch set 6 V +1 03/04/24, 15:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53867

  4. Willi Wehmeier uploaded patch set 7 CR +1 V +1 03/15/24, 07:26

  5. core-ci voted on patch set 7 V -1 03/15/24, 07:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54563

  6. Willi Wehmeier uploaded patch set 8 V -1 03/15/24, 08:04

  7. core-ci voted on patch set 8 V +1 03/15/24, 08:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54564

  8. Michael Telgkamp uploaded patch set 9 V +1 06/12/24, 09:01

  9. Michael Telgkamp commented on patch set 9 CR +1 V +1 06/12/24, 09:03

    Rebased patch and adjusted capitalization of identifiers.
  10. core-ci voted on patch set 9 V +1 06/12/24, 09:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59293

  11. Michael Telgkamp updated the commit message in patch set 10 CR +1 V +1 06/12/24, 09:08

  12. Michael Telgkamp voted on patch set 10 CR +1 V +1 06/12/24, 09:09

  13. core-ci voted on patch set 10 V +1 06/12/24, 09:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59295

  14. Jasmina Ließmann commented on patch set 10 06/12/24, 09:26

    BackendUtility.php:2054

    This looks duplicate with the content in row 2063-2065.
  15. Jasmina Ließmann uploaded patch set 11 CR +1 V +1 06/12/24, 09:34

  16. Jasmina Ließmann commented on patch set 11 06/12/24, 09:34

    BackendUtility.php:2054 Reply

    Done
  17. Michael Telgkamp voted on patch set 11 CR +1 V +1 06/12/24, 09:37

  18. Jasmina Ließmann uploaded patch set 12 CR +1 V +1 06/12/24, 09:38

  19. Michael Telgkamp voted on patch set 12 CR +1 V +1 06/12/24, 09:40

  20. Jasmina Ließmann voted on patch set 12 CR +1 V +1 06/12/24, 09:42

  21. core-ci voted on patch set 11 V +1 06/12/24, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59298

  22. core-ci voted on patch set 12 V +1 06/12/24, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59300

  23. Garvin Hicking voted on patch set 12 CR +1 V +1 06/12/24, 11:44

  24. Christian Kuhn voted on patch set 12 CR +2 V +2 06/12/24, 15:50

  25. Christian Kuhn merged patch set 13 06/12/24, 16:11