Review main Merged

81944[TASK] Respect not-nullable strings in `TableBuilder`

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 11/24/23, 09:19

Commit message

The doctrine team enforced types on a couple of classes
to not-nullable strings [1], for examle:

* `Column->setComment(string $comment)`
* `Column->getComment(): string

The `\TYPO3\CMS\Core\Database\Schema\Parser\TableBuilder`
is modified to ensure that a string is set by using a simple
string cast.

[1] https://github.com/doctrine/dbal/pull/3949

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Andreas Nedbal +1
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Andreas Nedbal +1
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Stefan Bürk uploaded patch set 1 11/23/23, 21:09

  2. Andreas Nedbal voted on patch set 1 CR +1 V +1 11/23/23, 21:12

  3. Christian Kuhn voted on patch set 1 CR +1 V +1 11/23/23, 21:12

  4. core-ci voted on patch set 1 V +1 11/23/23, 21:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49822

  5. Oli Bartsch voted on patch set 1 CR +1 V +1 11/23/23, 21:17

  6. Stefan Bürk voted on patch set 1 CR +2 V +2 11/23/23, 21:41

  7. Stefan Bürk merged patch set 2 11/23/23, 21:41

  8. Stefan Bürk wrote 11/24/23, 09:19

    Created a revert of this change as Ia92a8955951525e6c7a04bd9544f7d14c8be2e8e