Review 12.4 Merged

81953[BUGFIX] Properly iterate over extensions in extension manager

Andreas Kienast CR +2 V +2 Easy +22 −11 updated 11/24/23, 11:57

Commit message

When downloading or updating extension using extension manager, the
resulting extensions are now properly iterated using `Object.keys`.
This is necessary since the extensions are provided as objects instead
of simple arrays.

In addition, the relevant methods in ExtensionManagementService now
have proper type declarations and annotations.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 34

  1. Andreas Kienast uploaded patch set 1 11/24/23, 11:49

  2. core-ci voted on patch set 1 V +1 11/24/23, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49887

  3. Andreas Kienast voted on patch set 1 CR +2 V +2 11/24/23, 11:57

  4. Andreas Kienast merged patch set 2 11/24/23, 11:57