Review main Abandoned

81964[WIP][BUGFIX] Always call GU::trimExplode with a string

Oliver Klee CR 0 V 0 Normal +58 −50 updated 08/25/24, 10:10

Commit message

This helps avoid breakage when GeneralUtility will switch to
strict mode and GU::trimExplode will get native type declarations.

This change also prevents a whole bunch of possible invalid
array access warnings.

Resolves: #97602
Relates: #97578
Releases: main

typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php

Review

  • Code review CR 0
  • Verified V 0

Files 29

Show 9 more files

Review log 46

  1. Oliver Klee uploaded patch set 1 11/26/23, 08:46

  2. Oliver Klee marked it work in progress 11/26/23, 08:54

  3. Oliver Klee updated the commit message in patch set 2 11/26/23, 08:54

  4. core-ci voted on patch set 1 V -1 11/26/23, 08:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49940

  5. core-ci voted on patch set 2 V -1 11/26/23, 09:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49941

  6. Oliver Klee abandoned the change 08/25/24, 10:10