81965[TASK] Extract ext_tables.php loading to a factory
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Torben Hansen +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Torben Hansen +1
- Benni Mack +1
- core-ci +1 CI
Issues 3
Files 10
- Build/phpstan/phpstan-baseline.neon+0 −5
- typo3/sysext/core/Classes/Command/CacheWarmupCommand.php+7 −4
- typo3/sysext/core/Classes/Configuration/Extension/ExtTablesFactory.phpnew+107 −0
- typo3/sysext/core/Classes/Core/BootService.php4+6 −3
- typo3/sysext/core/Classes/Core/Bootstrap.php4+7 −3
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+0 −121
- typo3/sysext/core/Configuration/Services.yaml+5 −0
- typo3/sysext/core/Tests/Unit/Utility/AccessibleProxies/ExtensionManagementUtilityAccessibleProxy.php+0 −22
- typo3/sysext/core/Tests/Unit/Utility/ExtensionManagementUtilityTest.php+0 −122
- typo3/sysext/extensionmanager/Classes/Utility/InstallUtility.php+2 −2
Review log 1214
-
Christian Kuhn uploaded patch set 1 11/26/23, 13:08
-
core-ci voted on patch set 1 V +1 11/26/23, 13:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49950
-
Oliver Klee voted on patch set 1 V +1 11/26/23, 13:52
-
Oliver Klee commented on patch set 1 11/26/23, 13:58
Looks generally very good to me. I’ve commented a place where a change was unclear to me and another where we could improve the code structure.BootService.php:145Just for readability, I think that having two nested `if` would communicate the intended control flow of the code more clearly.Bootstrap.php:152This looks unrelated to me. Why is this line removed? -
Torben Hansen commented on patch set 1 CR +1 V +1 11/26/23, 18:11
Bootstrap.php:152ReplyThe method `setEventDispatcher` has been removed from `ExtensionManagementUtility` (as well as the whole EventDispatcher usage in that class) -
Christian Kuhn commented on patch set 1 11/26/23, 18:51
BootService.php:145Replythought about that, too, but decided to go with this since it's still simple enough to grasp to my perception. -
Oliver Klee commented on patch set 1 11/26/23, 20:33
BootService.php:145ReplyHonestly, this construct confused me, and I needed to think twice to understand what the purpose of the code was. That’s why I suggest changing the structure in order to save future code readers this confusion. :-)Bootstrap.php:152ReplyThat’s what I had gathered as well. My point was: Does this change remove the usage of the EventDispatcher in that class? (If I’m not mistaken, there was not usage left in the first place.) So I’d prefer to have that removal as a pre-patch to keep unrelated changes out of this changes, and to have single-purpose changes. Or am I missing something here? -
Christian Kuhn commented on patch set 1 11/27/23, 08:51
BootService.php:145ReplyDoneBootstrap.php:152ReplyEMU::setEventDispatcher() is removed with this patch, ext_tables stuff was last usage. -
Christian Kuhn uploaded patch set 2
CR +1V +111/27/23, 08:52 -
Torben Hansen voted on patch set 2 CR +1 V +1 11/27/23, 08:59
-
core-ci voted on patch set 2 V +1 11/27/23, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49969
-
Benni Mack voted on patch set 2 CR +1 V +1 11/27/23, 09:19
-
Christian Kuhn voted on patch set 2 CR +2 V +2 11/27/23, 09:20
-
Christian Kuhn merged patch set 3 11/27/23, 09:21