Review main Merged

81969[BUGFIX] Add safeguard in case normalizedParams are missing

Benjamin Franzke CR +2 V +2 Easy +2 −1 updated 11/27/23, 14:54

Commit message

With #100885 the availability of the normalizedParams request attribute
became a requirement for user sessions initialized with a custom PSR-7
request. Extensions like EXT:container relied on the fact that a plain
request object could be passed to `Bootstrap::initializeBackendUser()`.

This will be fixed in EXT:container[1] but in case other extensions
relied on this as well, a fallback is now provided.

[1] https://github.com/b13/container/pull/461

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Benjamin Franzke uploaded patch set 1 11/27/23, 08:05

  2. core-ci voted on patch set 1 V +1 11/27/23, 08:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49963

  3. Christian Kuhn voted on patch set 1 CR +1 V +1 11/27/23, 11:29

  4. Oli Bartsch voted on patch set 1 CR +1 V +1 11/27/23, 14:43

  5. Benjamin Franzke voted on patch set 1 CR +2 V +2 11/27/23, 14:54

  6. Benjamin Franzke merged patch set 2 11/27/23, 14:54