Review main Merged

81973[BUGFIX] Wait for initialized FormEngine in `TemplateCest`

Andreas Kienast CR +2 V +2 Easy +2 −0 updated 11/27/23, 13:14

Commit message

AC test reveal [1] that our code editor may be in a half-initialized
state before shutting down the test case, carrying over potential
JavaScript errors. To compensate this, `TemplateCest` now waits for the
target document and an additional 2 seconds to give the system a chance
to load everything properly.

[1] https://git.typo3.org/typo3/CI/cms/-/jobs/2778518

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 58

  1. Andreas Kienast uploaded patch set 1 11/27/23, 11:47

  2. core-ci voted on patch set 1 V +1 11/27/23, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49984

  3. core-ci commented on patch set 1 11/27/23, 12:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49985

  4. Andreas Kienast updated the commit message in patch set 2 V +1 11/27/23, 12:13

  5. Christian Kuhn voted on patch set 2 CR +1 V +1 11/27/23, 12:16

  6. core-ci voted on patch set 2 V +1 11/27/23, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49987

  7. Andreas Kienast voted on patch set 2 CR +2 V +2 11/27/23, 13:14

  8. Andreas Kienast merged patch set 3 11/27/23, 13:14