Review main Merged

81975[TASK] Avoid unnecessary null-coalesence operators etc

Benni Mack CR +2 V +2 Hard +84 −189 updated 12/01/23, 07:40

Commit message

When PHP 8.0 support was added, a lot of places
received extra checks with the $conf ?? [].

PHPStan complained about this now, as methods
already have native PHP types added now, and the
check is not needed anymore, so it can be simplified

A few other places did not receive proper PHPdoc
annotations which has been fixed as well.

In addition, some str_ends_with calls are migrated.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 24

Show 4 more files