Review main Merged

81977[BUGFIX] Add aria-label to link wizard tca button

Christian Rath-Ulrich CR +2 V +2 Easy +11 −1 updated 12/07/23, 14:14

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Christian Rath-Ulrich +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Christian Rath-Ulrich +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1419

  1. Christian Rath-Ulrich uploaded patch set 1 11/27/23, 15:59

  2. core-ci voted on patch set 1 V +1 11/27/23, 16:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50012

  3. Patrick Schriner commented on patch set 1 CR -1 11/27/23, 20:02

    LinkPopup.php:100

    typo: should be aria-label
  4. Christian Rath-Ulrich uploaded patch set 2 CR -1 V +1 11/28/23, 08:19

  5. Christian Rath-Ulrich commented on patch set 2 11/28/23, 08:19

    LinkPopup.php:100 Reply

    fixed thx
  6. core-ci voted on patch set 2 V +1 11/28/23, 08:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50044

  7. Oli Bartsch commented on patch set 2 11/28/23, 12:03

    LinkPopup.php:40

    Please move this method after the public render(). Additionally, there is no need to make this method static.
  8. Christian Rath-Ulrich uploaded patch set 3 V +1 11/28/23, 13:56

  9. Christian Rath-Ulrich commented on patch set 3 11/28/23, 13:56

    LinkPopup.php:40 Reply

    done
  10. core-ci voted on patch set 3 V +1 11/28/23, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50054

  11. Oli Bartsch uploaded patch set 4 V +1 11/28/23, 14:37

  12. Oli Bartsch voted on patch set 4 CR +1 V +1 11/28/23, 14:37

  13. core-ci voted on patch set 4 V +1 11/28/23, 14:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50058

  14. Patrick Schriner uploaded patch set 5 CR +1 V +1 12/04/23, 10:19

  15. Oli Bartsch voted on patch set 5 CR +1 V +1 12/04/23, 10:22

  16. core-ci voted on patch set 5 V +1 12/04/23, 10:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50312

  17. Christian Rath-Ulrich voted on patch set 5 CR +1 V +1 12/06/23, 09:15

  18. Christian Kuhn voted on patch set 5 CR +2 V +2 12/07/23, 14:14

  19. Christian Kuhn merged patch set 6 12/07/23, 14:14