Review main Merged

81978[BUGFIX] Throw dedicated exception for invalid request URL on CLI

Oli Bartsch CR +2 V +2 Easy +37 −1 updated 11/29/23, 20:27

Commit message

Usage of ServerRequestFactory::fromGlobals() on
CLI is discouraged as the request url, used to
create the request is invalid, except the
$_SERVER variable is adjusted beforehand.

To properly inform the developer, a dedicated
exception is now being thrown, if in CLI context.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1013

  1. Oli Bartsch uploaded patch set 1 11/27/23, 16:07

  2. Mathias Brodala commented on patch set 1 11/27/23, 16:15

    ServerRequestFactory.php:67

    Shouldn't this be "http://localhost/"; at least?
  3. core-ci voted on patch set 1 V +1 11/27/23, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50014

  4. Oli Bartsch uploaded patch set 2 V +1 11/27/23, 17:28

  5. core-ci voted on patch set 2 V +1 11/27/23, 17:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50023

  6. Stefan Bürk updated the commit message in patch set 3 V +1 11/27/23, 17:42

  7. Stefan Bürk voted on patch set 3 CR +1 V +1 11/27/23, 17:43

  8. Oli Bartsch commented on patch set 3 11/27/23, 17:46

    ServerRequestFactory.php:67 Reply

    Done
  9. Christian Kuhn commented on patch set 3 CR -1 11/27/23, 17:49

    it would be better to get rid of GU::getindpenv() altogether. That's top-1 on the list of "needs to be deprecated" methods for v13. Plesase give us some time to see if we should have a different v13 version of that patch.
  10. core-ci voted on patch set 3 V +1 11/27/23, 17:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50024

  11. Christian Kuhn voted on patch set 3 CR +1 V +1 11/29/23, 19:38

  12. Oli Bartsch voted on patch set 3 CR +2 V +2 11/29/23, 20:26

  13. Oli Bartsch merged patch set 4 11/29/23, 20:27