81993[BUGFIX] Fix value-picker initialization race condition
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
- Andreas Kienast +1
-
Verified V +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 2
Review log 812
-
Benjamin Franzke uploaded patch set 1 11/28/23, 13:18
-
core-ci voted on patch set 1 V +1 11/28/23, 13:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50052
-
Benjamin Franzke uploaded patch set 2
V +111/28/23, 13:37 -
core-ci voted on patch set 2 V +1 11/28/23, 13:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50053
-
Benjamin Franzke uploaded patch set 3
V +111/29/23, 08:20 -
core-ci voted on patch set 3 V -1 11/29/23, 08:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50091
-
core-ci voted on patch set 3 V +1 11/29/23, 08:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50091
-
Christian Kuhn voted on patch set 3 CR +1 V +1 11/29/23, 18:15
-
Andreas Kienast voted on patch set 3 CR +1 11/30/23, 10:02
-
Oli Bartsch voted on patch set 3 CR +2 V +2 12/01/23, 07:17
-
Oli Bartsch merged patch set 4 12/01/23, 07:33
-
Benjamin Franzke commented on patch set 4 12/01/23, 07:44
Sorry, I actually wanted to improve this commit message a bit, but forget about it, so I'm leaving it here as post-merge note: Tiny correction on this statement that turned out to be not 100% correct. It's not really the server that is busy (our html content is not streamed, so the server is/was ready), but basically a parser timing "thingy" that were caused on development/ci machines when xdebug (thing of parallel requests) and browser dom parsing were running in parallel. The behaviour we're working around here is a known wont-fix issue/decision that connectedCallback is basically defined to run early: See https://github.com/WICG/webcomponents/issues/551 was marked as wont-fix in chromium/blink: https://bugs.chromium.org/p/chromium/issues/detail?id=639847