Review main Merged

81994[BUGFIX] Properly set allowed fields for record download

Oli Bartsch CR +2 V +2 Easy +4 −4 updated 11/29/23, 04:15

Commit message

Since #101859, the `setFields` property of the record
list, which contains the fields to show / download is
initialized in the start() method.

To enable the "all columns" option again, overwriting
of the property is now done after calling start().

Additionally, the module data call is removed as this
is done by record list already.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 45

  1. Oli Bartsch uploaded patch set 1 11/28/23, 14:21

  2. core-ci voted on patch set 1 V +1 11/28/23, 14:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50055

  3. Benni Mack voted on patch set 1 CR +1 V +1 11/28/23, 21:16

  4. Christian Kuhn voted on patch set 1 CR +2 V +2 11/29/23, 04:15

  5. Christian Kuhn merged patch set 2 11/29/23, 04:15