Review main Merged

81997[TASK] Remove `_TOGGLE` handling from FlexForms

Andreas Kienast CR +2 V +2 Normal +58 −76 updated 11/29/23, 20:41

Commit message

Historically, FlexForms store their section collapsing state within the
flex structure in the database, having the impact that the state is
reflected to every backend user.

The internal `_TOGGLE` field is removed from any handling, the collapse
state is now stored in backend user's localStorage.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 28

Show 8 more files

Review log 1012

  1. Andreas Kienast uploaded patch set 1 11/28/23, 15:20

  2. core-ci voted on patch set 1 V +1 11/28/23, 15:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50060

  3. Benni Mack commented on patch set 1 11/29/23, 08:28

    can't we just remove it instead of deprecating it?
  4. Andreas Kienast commented on patch set 1 11/29/23, 09:30

    Reply

    Deprecating first was just a test to see if anything breaks at all. I'll do some more tests whether this is a breaking change (handling removed but FF in database still contains `_TOGGLE`) and based on that finalize the patch.
  5. Andreas Kienast uploaded patch set 2 V +1 11/29/23, 10:08

  6. Andreas Kienast uploaded patch set 3 11/29/23, 10:08

  7. core-ci voted on patch set 3 V +1 11/29/23, 10:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50100

  8. Christian Kuhn commented on patch set 3 CR -1 11/29/23, 10:16

    temp -1 - i'll review in detail since i know the php side pretty well.
  9. Christian Kuhn voted on patch set 3 CR +1 V +1 11/29/23, 20:29

  10. Stefan Bürk voted on patch set 3 CR +1 V +1 11/29/23, 20:35

  11. Christian Kuhn voted on patch set 3 CR +2 V +2 11/29/23, 20:41

  12. Christian Kuhn merged patch set 4 11/29/23, 20:41