81997[TASK] Remove `_TOGGLE` handling from FlexForms
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 28
- Build/Sources/TypeScript/backend/form-engine/container/flex-form-container-container.ts+16 −10
- Build/Sources/TypeScript/backend/form-engine/container/flex-form-section-container.ts+4 −0
- typo3/sysext/backend/Classes/Controller/FormFlexAjaxController.php+0 −1
- typo3/sysext/backend/Classes/Form/Container/FlexFormContainerContainer.php+3 −15
- typo3/sysext/backend/Classes/Form/Container/FlexFormSectionContainer.php+0 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaFlexProcess.php+0 −4
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/flex-form-container-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/flex-form-section-container.js+1 −1
- typo3/sysext/core/Classes/Configuration/FlexForm/FlexFormTools.php+2 −3
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+0 −1
- typo3/sysext/core/Documentation/Changelog/13.0/Important-102551-FlexFormSection_TOGGLEControlRemoved.rstnew+31 −0
- typo3/sysext/core/Tests/Functional/Configuration/FlexForm/Fixtures/cleanFlexFormHandlesValuesOfComplexDataStructureValueExpected.xml+0 −2
- typo3/sysext/core/Tests/Functional/Configuration/FlexForm/Fixtures/cleanFlexFormHandlesValuesOfComplexDataStructureValueInput.xml+0 −2
- typo3/sysext/core/Tests/Functional/Database/Fixtures/ReferenceIndex/UpdateIndexHandlesSoftrefForFlexFieldContainerElementFieldsImport.csv+0 −4
- typo3/sysext/core/Tests/Functional/Database/Fixtures/ReferenceIndex/UpdateIndexHandlesSoftrefForFlexFieldContainerElementFieldsResult.csv+0 −4
- typo3/sysext/core/Tests/Functional/DataScenarios/FlexSectionContainer/DataSet/ImportDefault.csv+0 −2
- typo3/sysext/core/Tests/Functional/DataScenarios/FlexSectionContainer/DataSet/ImportDefaultWorkspaces.csv+0 −2
- typo3/sysext/core/Tests/Functional/DataScenarios/FlexSectionContainer/Modify/DataSet/changeSorting.csv+0 −2
- typo3/sysext/core/Tests/Functional/DataScenarios/FlexSectionContainer/Modify/DataSet/deleteSection.csv+0 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/FlexSectionContainer/WorkspacesDiscard/DataSet/changeSorting.csv+0 −2
Show 8 more files
- typo3/sysext/core/Tests/Functional/DataScenarios/FlexSectionContainer/WorkspacesDiscard/DataSet/deleteSection.csv+0 −2
- typo3/sysext/core/Tests/Functional/DataScenarios/FlexSectionContainer/WorkspacesModify/DataSet/changeSorting.csv+0 −4
- typo3/sysext/core/Tests/Functional/DataScenarios/FlexSectionContainer/WorkspacesModify/DataSet/deleteSection.csv+0 −3
- typo3/sysext/core/Tests/Functional/DataScenarios/FlexSectionContainer/WorkspacesPublish/DataSet/changeSorting.csv+0 −2
- typo3/sysext/core/Tests/Functional/DataScenarios/FlexSectionContainer/WorkspacesPublish/DataSet/deleteSection.csv+0 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/FlexSectionContainer/WorkspacesPublishAll/DataSet/changeSorting.csv+0 −2
- typo3/sysext/core/Tests/Functional/DataScenarios/FlexSectionContainer/WorkspacesPublishAll/DataSet/deleteSection.csv+0 −1
- typo3/sysext/core/Tests/Unit/Service/FlexFormServiceTest.php+0 −2
Review log 1012
-
Andreas Kienast uploaded patch set 1 11/28/23, 15:20
-
core-ci voted on patch set 1 V +1 11/28/23, 15:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50060
-
Benni Mack commented on patch set 1 11/29/23, 08:28
can't we just remove it instead of deprecating it? -
Andreas Kienast commented on patch set 1 11/29/23, 09:30
Reply
Deprecating first was just a test to see if anything breaks at all. I'll do some more tests whether this is a breaking change (handling removed but FF in database still contains `_TOGGLE`) and based on that finalize the patch. -
Andreas Kienast uploaded patch set 2
V +111/29/23, 10:08 -
Andreas Kienast uploaded patch set 3 11/29/23, 10:08
-
core-ci voted on patch set 3 V +1 11/29/23, 10:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50100
-
Christian Kuhn commented on patch set 3 CR -1 11/29/23, 10:16
temp -1 - i'll review in detail since i know the php side pretty well. -
Christian Kuhn voted on patch set 3 CR +1 V +1 11/29/23, 20:29
-
Stefan Bürk voted on patch set 3 CR +1 V +1 11/29/23, 20:35
-
Christian Kuhn voted on patch set 3 CR +2 V +2 11/29/23, 20:41
-
Christian Kuhn merged patch set 4 11/29/23, 20:41