Review main Merged

81998[TASK] Update PHPStan & friends

Oliver Klee CR +2 V +2 Easy +24 −19 updated 11/29/23, 03:33

Commit message

The new version fixes a false positive, adds a second
warning for a problem that already is logged in the baseline,
and sadly introduces one new false positive.

> composer req --dev phpstan/phpstan:^1.10.46
> composer req --dev phpstan/phpstan-phpunit:^1.3.15
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 56

  1. Oliver Klee uploaded patch set 1 11/28/23, 15:54

  2. core-ci voted on patch set 1 V +1 11/28/23, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50062

  3. Wouter Wolters voted on patch set 1 CR +1 V +1 11/28/23, 17:45

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 11/28/23, 19:57

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 11/29/23, 03:32

  6. Christian Kuhn merged patch set 2 11/29/23, 03:33