82000[WIP][TASK] Make PageArguments->getPageType() an int
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 20
- Build/phpstan/phpstan-baseline.neon+0 −5
- typo3/sysext/core/Classes/Routing/Enhancer/AbstractEnhancer.php+2 −2
- typo3/sysext/core/Classes/Routing/PageArguments.php+4 −4
- typo3/sysext/core/Classes/Routing/PageRouter.php+3 −3
- typo3/sysext/core/Tests/Unit/Routing/PageRouterTest.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Mvc/Web/RequestBuilderTest.php+2 −2
- typo3/sysext/fluid/Classes/ViewHelpers/CObjectViewHelper.php+1 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/ActionViewHelperTest.php+3 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/PageViewHelperTest.php+2 −2
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/TypolinkViewHelperTest.php+1 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/ActionViewHelperTest.php+3 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/PageViewHelperTest.php+2 −2
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/FormViewHelperTest.php+1 −1
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+2 −3
- typo3/sysext/frontend/Classes/Typolink/AbstractTypolinkBuilder.php+2 −2
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+2 −2
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php+1 −1
- typo3/sysext/frontend/Tests/Unit/Middleware/PageArgumentValidatorTest.php+4 −4
- typo3/sysext/frontend/Tests/Unit/Typolink/PageLinkBuilderTest.php+1 −1
- typo3/sysext/redirects/Classes/Service/RedirectService.php+1 −1
Review log 45
-
Christian Kuhn uploaded patch set 1 11/29/23, 03:16
-
core-ci voted on patch set 1 V +1 11/29/23, 03:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50074
-
Benni Mack commented on patch set 1 CR -2 11/29/23, 06:54
I need to consider some things here first -
Christian Kuhn commented on patch set 1 CR -2 11/29/23, 07:03
will solve differently. -
Christian Kuhn abandoned the change 11/29/23, 07:03