Review main Merged

82006[TASK] Extract WS-related code from BE_USER

Benni Mack CR +2 V +2 Normal +101 −65 updated 11/29/23, 11:11

Commit message

The main goal of this change is to use constants
for sys_workspace.publish_access options to make
the code more readable.

This is made possible by moving the method
BE_USER->workspacePublishAccess to EXT:workspaces

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1418

  1. Benni Mack uploaded patch set 1 11/29/23, 07:06

  2. core-ci voted on patch set 1 V +1 11/29/23, 07:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50086

  3. Benni Mack updated the commit message in patch set 2 V +1 11/29/23, 07:50

  4. core-ci voted on patch set 2 V +1 11/29/23, 07:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50090

  5. Oli Bartsch commented on patch set 2 CR -1 11/29/23, 09:19

    On it
  6. Oli Bartsch uploaded patch set 3 CR -1 V +1 11/29/23, 10:11

  7. Oli Bartsch commented on patch set 3 CR +1 V +1 11/29/23, 10:13

    Reply

    Done
  8. Oli Bartsch uploaded patch set 4 CR +1 V +1 11/29/23, 10:14

  9. Oli Bartsch voted on patch set 4 CR +1 V +1 11/29/23, 10:14

  10. core-ci voted on patch set 4 V +1 11/29/23, 10:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50102

  11. Christian Kuhn voted on patch set 4 CR +1 V +1 11/29/23, 10:20

  12. Benni Mack voted on patch set 4 CR -1 11/29/23, 10:22

  13. Benni Mack uploaded patch set 5 CR +1 V +1 11/29/23, 10:22

  14. core-ci voted on patch set 5 V +1 11/29/23, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50103

  15. Oli Bartsch voted on patch set 5 CR +1 V +1 11/29/23, 10:48

  16. Christian Kuhn voted on patch set 5 CR +1 V +1 11/29/23, 11:10

  17. Benni Mack voted on patch set 5 CR +2 V +2 11/29/23, 11:11

  18. Benni Mack merged patch set 6 11/29/23, 11:11