82009[TASK] Rework DataHandler->doesBranchExist
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Christian Kuhn +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 4
Review log 1217
-
Benni Mack uploaded patch set 1 11/29/23, 08:23
-
core-ci voted on patch set 1 V -1 11/29/23, 08:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50092
-
Benni Mack uploaded patch set 2
V -111/30/23, 09:13 -
core-ci voted on patch set 2 V +1 11/30/23, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50154
-
Benni Mack updated the commit message in patch set 3
V +111/30/23, 09:22 -
Benni Mack updated the commit message in patch set 4 11/30/23, 09:22
-
core-ci voted on patch set 3 V +1 11/30/23, 09:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50155
-
core-ci voted on patch set 4 V +1 11/30/23, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50156
-
Andreas Kienast commented on patch set 4 11/30/23, 10:01
DataHandler.php:5435`$forceHardDelete` is already a bool, the cast seems superfluous. -
Benni Mack uploaded patch set 5
V +111/30/23, 12:18 -
core-ci voted on patch set 5 V +1 11/30/23, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50162
-
Benni Mack commented on patch set 5 11/30/23, 12:32
DataHandler.php:5427ReplyDoneDataHandler.php:5435ReplyDone -
Andreas Kienast voted on patch set 5 CR +1 12/04/23, 09:13
-
Oli Bartsch voted on patch set 5 CR +1 V +1 12/04/23, 17:20
-
Christian Kuhn voted on patch set 5 CR +1 V +1 12/04/23, 17:51
-
Benni Mack voted on patch set 5 CR +2 V +2 12/04/23, 18:11
-
Benni Mack merged patch set 6 12/04/23, 18:11
DataHandler.php:5427