Review main Merged

82009[TASK] Rework DataHandler->doesBranchExist

Benni Mack CR +2 V +2 Normal +35 −44 updated 12/04/23, 18:11

Commit message

This change adapts DataHandler->doesBranchExist
to work with an array instead of a stringlist
and the magic "-1" value.

In addition, related internal methods also now
use proper PHP native types.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1217

  1. Benni Mack uploaded patch set 1 11/29/23, 08:23

  2. core-ci voted on patch set 1 V -1 11/29/23, 08:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50092

  3. Benni Mack uploaded patch set 2 V -1 11/30/23, 09:13

  4. core-ci voted on patch set 2 V +1 11/30/23, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50154

  5. Benni Mack updated the commit message in patch set 3 V +1 11/30/23, 09:22

  6. Benni Mack updated the commit message in patch set 4 11/30/23, 09:22

  7. core-ci voted on patch set 3 V +1 11/30/23, 09:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50155

  8. core-ci voted on patch set 4 V +1 11/30/23, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50156

  9. Andreas Kienast commented on patch set 4 11/30/23, 10:01

    DataHandler.php:5427

    Code-wise, `doesBranchExist()` may return null. The next assignment then may fail.

    DataHandler.php:5435

    `$forceHardDelete` is already a bool, the cast seems superfluous.
  10. Benni Mack uploaded patch set 5 V +1 11/30/23, 12:18

  11. core-ci voted on patch set 5 V +1 11/30/23, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50162

  12. Benni Mack commented on patch set 5 11/30/23, 12:32

    DataHandler.php:5427 Reply

    Done

    DataHandler.php:5435 Reply

    Done
  13. Andreas Kienast voted on patch set 5 CR +1 12/04/23, 09:13

  14. Oli Bartsch voted on patch set 5 CR +1 V +1 12/04/23, 17:20

  15. Christian Kuhn voted on patch set 5 CR +1 V +1 12/04/23, 17:51

  16. Benni Mack voted on patch set 5 CR +2 V +2 12/04/23, 18:11

  17. Benni Mack merged patch set 6 12/04/23, 18:11