Review 12.4 Merged

82014[TASK] Early return in case title tag should not be rendered

Christian Kuhn CR +2 V +2 Easy +5 −4 updated 11/29/23, 19:13

Commit message

To avoid unnecessary initialization of page
title providers and calling any stdWrap, an
early return is added to `TSFE::generatePageTitle`
for the case that `noPageTitle` is set to "2",
as this means do not render the title tag at all.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Christian Kuhn commented on patch set 1 11/29/23, 19:02

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/29/23, 19:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50138

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 11/29/23, 19:13

  4. Christian Kuhn merged patch set 2 11/29/23, 19:13