Review 12.4 Merged

82016[BUGFIX] Use config.sendCacheHeaders only for cacheable content

Benni Mack CR +2 V +2 Easy +14 −24 updated 11/30/23, 13:16

Commit message

This changes the behaviour of config.sendCacheHeaders = 1.

When a non-cacheable option is used, the HTTP Response
Headers for ensuring that a response should never
be cached (that is Cache-Control: private, no-store)
should be sent at any time, as it could contain
sensitive information, regardless of the TypoScript option.

The TypoScript option config.sendCacheHeaders is
then only used to actually explicitly send the headers
for a fully client-cacheable page (e.g. for a proxy), to
explicitly allow the cached content to be stored
for a defined amount of time.

In addition, a lot of tests have been adapted to
remove this option as it does not have any effect
in the tests if the option is set.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 13

Review log 34

  1. Benni Mack commented on patch set 1 11/30/23, 13:03

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/30/23, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50168

  3. Benni Mack voted on patch set 1 CR +2 V +2 11/30/23, 13:16

  4. Benni Mack merged patch set 2 11/30/23, 13:16