Review main Merged

82033[BUGFIX] Loose return value in HtmlentitiesDecodeViewHelper

Achim Fritz CR +2 V +2 Easy +4 −8 updated 11/29/23, 16:30

Commit message

The return value of HtmlentitiesDecodeViewHelper can be null
e.g. {foo -> f:format.htmlentitiesDecode()}
with foo might be undefined

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 69

  1. Achim Fritz uploaded patch set 1 11/29/23, 13:38

  2. core-ci voted on patch set 1 V -1 11/29/23, 13:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50115

  3. Achim Fritz uploaded patch set 2 V -1 11/29/23, 14:07

  4. core-ci voted on patch set 2 V -1 11/29/23, 14:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50117

  5. Benni Mack updated the commit message in patch set 3 V -1 11/29/23, 15:45

  6. core-ci voted on patch set 3 V +1 11/29/23, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50126

  7. Benni Mack voted on patch set 3 CR +1 V +1 11/29/23, 16:18

  8. Oli Bartsch voted on patch set 3 CR +2 V +2 11/29/23, 16:21

  9. Oli Bartsch merged patch set 4 11/29/23, 16:30