Review main Merged

82038[BUGFIX] Prevent endless loop in t3editor when using '/*' literal

Garvin Hicking CR +2 V +2 Easy +3 −3 updated 11/30/23, 08:43

Commit message

When entering the sequence "/*" into any t3editor instance
(i.e. TypoScript editor in the backend), it puts the browser in an
endless loop.

The reason is that the method `stream.next()` declares to either return
a string value or `void` (=`undefined`), but the code checks for `null`.
The check is now fixed and another cases where a loose null comparison
was used is adapted as well. Note that a loose null comparison between
null and undefined return equality, but a strict comparison doesn't.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 2