Review main Merged

82047[TASK] Avoid TSFE->pSetup

Christian Kuhn CR +2 V +2 Hard +400 −415 updated 11/30/23, 12:01

Commit message

Internal property TypoScriptFrontendController->pSetup
contains the TypoScript PAGE TS array of the current
type/typeNum.

FE RequestHandler uses this, but it can be derived directly
from the current type in Request attribute 'routing'
combined with a TS array lookup in Request attribute
'controller.typoscript'.

The patch avoids and removes TSFE->pSetup which resolves
a spaghetti dependency from TypoScriptFrontendController
up into RequestHandler.

Main method processHtmlBasedRenderingSettings() is
streamlined carefully along the way.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 4