Review main Merged

82049[TASK] Clean up workspaces-related code

Benni Mack CR +2 V +2 Hard +49 −514 updated 12/05/23, 09:03

Commit message

This change most notably modifies EXT:workspaces
where various places do not throw a custom exception
anymore due to strict typing in PHP.

In addition, the language file "locallang_mod_user_ws.xlf"
has been removed, as it did not contain any useful labels
anymore, and were part of the "old" (pre-ExtJS) module.

In order to improve code readability, some methods have
been changed or renamed, or legacy comments have been
removed. Constants for internal stages are now used
everywhere.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 7