Review main Merged

82051[BUGFIX] Add aria-checked attribute for clipboard state

Patrick Schriner CR +2 V +2 Easy +2 −2 updated 12/06/23, 09:57

Commit message

The current highlighting for the selected clipboard mode is purely
decorative and thereby impossible to use for screen readers.

This adds a proper aria-checked attribute to show the current state.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Patrick Schriner uploaded patch set 1 11/30/23, 13:34

  2. core-ci voted on patch set 1 V +1 11/30/23, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50169

  3. Oli Bartsch voted on patch set 1 CR +1 V +1 12/01/23, 07:03

  4. Garvin Hicking commented on patch set 1 CR +1 V +1 12/06/23, 09:15

    (First I thought if this would dynamically be altered properly; but since the checkbox state only changes on a full page reload, that's not an issue)
  5. Oli Bartsch voted on patch set 1 CR +2 V +2 12/06/23, 09:46

  6. Oli Bartsch merged patch set 2 12/06/23, 09:57