82058[BUGFIX] Fix accessibility of filelist
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 8
- Build/Sources/Sass/component/_table.scss+7 −0
- Build/Sources/TypeScript/backend/context-menu.ts+8 −0
- typo3/sysext/backend/Classes/Utility/BackendUtility.php2+24 −1
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −0
- typo3/sysext/backend/Resources/Public/JavaScript/context-menu.js+1 −1
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+6 −0
- typo3/sysext/core/Tests/Acceptance/Application/FileList/FileClipboardCest.php+1 −1
- typo3/sysext/filelist/Classes/FileList.php8+16 −8
Review log 1929
Show 24 earlier messages
-
Till Gräger uploaded patch set 1 12/01/23, 09:57
-
core-ci voted on patch set 1 V -1 12/01/23, 10:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50204
-
Till Gräger uploaded patch set 2
V -112/05/23, 12:17 -
core-ci voted on patch set 2 V -1 12/05/23, 12:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50369
-
Garvin Hicking commented on patch set 2 12/06/23, 08:46
(Can't commit too much on the accessibility itself, but some thoughts/typo hints)BackendUtility.php:1918IMO using additional attributes should not decide using a different HTML basic element. I'd say either we should try to not depend on '<a>' completely with this method, or we might need a fresh/new method for this like `wrapClickMenuOnIconAsButton`?FileList.php:468Typo, should be aria-labelFileList.php:506Typo (see above) -
Till Gräger uploaded patch set 3
V -112/06/23, 11:00 -
core-ci voted on patch set 3 V -1 12/06/23, 11:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50412
-
Till Gräger uploaded patch set 4
V -112/06/23, 11:24 -
core-ci voted on patch set 4 V +1 12/06/23, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50415
-
Christian Rath-Ulrich commented on patch set 4 CR +1 V +1 12/14/23, 19:15
FileList.php:468ReplyDoneFileList.php:506ReplyDone -
Simon Schaufelberger commented on patch set 4 CR -1 12/15/23, 07:39
FileList.php:4672 spaces before htmlspecialcharsFileList.php:937buttons don't have a href attribute AFAIK or am I wrong? -
Christian Rath-Ulrich uploaded patch set 5
CR +1V +101/30/24, 19:55 -
Christian Rath-Ulrich commented on patch set 5 01/30/24, 19:56
FileList.php:467ReplyDoneFileList.php:937ReplyDone -
core-ci voted on patch set 5 V -1 01/30/24, 20:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52518
-
core-ci commented on patch set 5 02/07/24, 15:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52518
-
Christian Rath-Ulrich uploaded patch set 6
V -102/12/24, 11:12 -
core-ci voted on patch set 6 V -1 02/12/24, 11:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53076
-
Christian Rath-Ulrich uploaded patch set 7
V -102/12/24, 11:25 -
core-ci voted on patch set 7 V +1 02/12/24, 11:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53079
-
Simon Schaufelberger commented on patch set 7 04/21/24, 21:25
@till.graeger@web.de would you do a rebase please? -
Oli Bartsch uploaded patch set 8
V +104/22/24, 07:54 -
Oli Bartsch commented on patch set 8 04/22/24, 07:54
Reply
Done -
core-ci voted on patch set 8 V +1 04/22/24, 08:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56474
-
Simon Schaufelberger commented on patch set 8 CR +1 04/22/24, 08:22
BackendUtility.php:1918ReplyDone -
Benni Mack updated the commit message in patch set 9
CR +1V +110/18/24, 13:29 -
core-ci voted on patch set 9 V -1 10/18/24, 21:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67972
-
Benni Mack commented on patch set 9 12/10/24, 16:19
will there be any progress? Otherwise I suggest to abandon this change, as other patches already fixed some areas. -
Benni Mack marked it work in progress 01/21/25, 15:33
-
Benjamin Kott abandoned the change 02/03/25, 13:35
This patch contained already addressed issues. All leftovers where extracted and finished in different patches - as these changes only scratches the surface. https://review.typo3.org/c/Packages/TYPO3.CMS/+/82058 https://review.typo3.org/c/Packages/TYPO3.CMS/+/87873 https://review.typo3.org/c/Packages/TYPO3.CMS/+/87856