Review main Abandoned

82058[BUGFIX] Fix accessibility of filelist

Till Gräger CR 0 V 0 Normal +64 −11 updated 02/03/25, 13:35

Commit message

added aria-title, aria-lable and aria-controls to Icons in the filelist.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 8

Review log 1929

Show 24 earlier messages
  1. Till Gräger uploaded patch set 1 12/01/23, 09:57

  2. core-ci voted on patch set 1 V -1 12/01/23, 10:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50204

  3. Till Gräger uploaded patch set 2 V -1 12/05/23, 12:17

  4. core-ci voted on patch set 2 V -1 12/05/23, 12:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50369

  1. Garvin Hicking commented on patch set 2 12/06/23, 08:46

    (Can't commit too much on the accessibility itself, but some thoughts/typo hints)

    BackendUtility.php:1918

    IMO using additional attributes should not decide using a different HTML basic element. I'd say either we should try to not depend on '<a>' completely with this method, or we might need a fresh/new method for this like `wrapClickMenuOnIconAsButton`?

    FileList.php:468

    Typo, should be aria-label

    FileList.php:506

    Typo (see above)
  2. Till Gräger uploaded patch set 3 V -1 12/06/23, 11:00

  3. core-ci voted on patch set 3 V -1 12/06/23, 11:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50412

  4. Till Gräger uploaded patch set 4 V -1 12/06/23, 11:24

  5. core-ci voted on patch set 4 V +1 12/06/23, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50415

  6. Christian Rath-Ulrich commented on patch set 4 CR +1 V +1 12/14/23, 19:15

    FileList.php:468 Reply

    Done

    FileList.php:506 Reply

    Done
  7. Simon Schaufelberger commented on patch set 4 CR -1 12/15/23, 07:39

    FileList.php:467

    2 spaces before htmlspecialchars

    FileList.php:937

    buttons don't have a href attribute AFAIK or am I wrong?
  8. Christian Rath-Ulrich uploaded patch set 5 CR +1 V +1 01/30/24, 19:55

  9. Christian Rath-Ulrich commented on patch set 5 01/30/24, 19:56

    FileList.php:467 Reply

    Done

    FileList.php:937 Reply

    Done
  10. core-ci voted on patch set 5 V -1 01/30/24, 20:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52518

  11. core-ci commented on patch set 5 02/07/24, 15:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52518

  12. Christian Rath-Ulrich uploaded patch set 6 V -1 02/12/24, 11:12

  13. core-ci voted on patch set 6 V -1 02/12/24, 11:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53076

  14. Christian Rath-Ulrich uploaded patch set 7 V -1 02/12/24, 11:25

  15. core-ci voted on patch set 7 V +1 02/12/24, 11:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53079

  16. Simon Schaufelberger commented on patch set 7 04/21/24, 21:25

    @till.graeger@web.de would you do a rebase please?
  17. Oli Bartsch uploaded patch set 8 V +1 04/22/24, 07:54

  18. Oli Bartsch commented on patch set 8 04/22/24, 07:54

    Reply

    Done
  19. core-ci voted on patch set 8 V +1 04/22/24, 08:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56474

  20. Simon Schaufelberger commented on patch set 8 CR +1 04/22/24, 08:22

    BackendUtility.php:1918 Reply

    Done
  21. Benni Mack updated the commit message in patch set 9 CR +1 V +1 10/18/24, 13:29

  22. core-ci voted on patch set 9 V -1 10/18/24, 21:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67972

  23. Benni Mack commented on patch set 9 12/10/24, 16:19

    will there be any progress? Otherwise I suggest to abandon this change, as other patches already fixed some areas.
  24. Benni Mack marked it work in progress 01/21/25, 15:33

  25. Benjamin Kott abandoned the change 02/03/25, 13:35

    This patch contained already addressed issues. All leftovers where extracted and finished in different patches - as these changes only scratches the surface. https://review.typo3.org/c/Packages/TYPO3.CMS/+/82058 https://review.typo3.org/c/Packages/TYPO3.CMS/+/87873 https://review.typo3.org/c/Packages/TYPO3.CMS/+/87856