Review main Abandoned Breaking

82060[WIP][!!!][FEATURE] Extract CacheFlush handling from DataHandler

Benni Mack CR 0 V 0 Hard +633 −300 updated 01/20/24, 22:38

Commit message

This change moves "clearCacheCmd" out of DataHandler,
and migrates the respective hooks into PSR-14 events.

$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_tcemain.php']['clearPageCacheEval']
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_tcemain.php']['clearCachePostProc']

Review

  • Code review CR 0
  • Verified V 0

Files 6

Review log 46

  1. Benni Mack uploaded patch set 1 12/01/23, 11:05

  2. core-ci voted on patch set 1 V -1 12/01/23, 11:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50207

  3. Benni Mack uploaded patch set 2 V -1 12/01/23, 11:20

  4. core-ci voted on patch set 2 V -1 12/01/23, 11:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50208

  5. Christian Kuhn commented on patch set 2 CR -1 12/01/23, 12:56

    Unresolved

    Yeah. We need to improve the cache flush strategies: It tends to do things far too often and can become the most important bottleneck in DataHandler easily. I'm not satisfied with the proposed architecture, though. I think we should establish something similar as we've done with ReferenceIndexUpdater: Have a simple API rather exclusively for DH to properly 'register' flushes and suppress duplicate registrations already. Then a 'fire' method that is called at the very end to perform the actions, probably using a second class that may reside in Cache namespace, maybe not, though. Also, I don't like the two setters much - those arguments should be hand over to the register methods if needed. All in all, I think we should do some more iterations here to come up with a more simple structure than just extracting everything with this patch. What do you think?
  6. Benni Mack abandoned the change 01/20/24, 22:38

    wont do then.