Review 12.4 Merged

82062[TASK] Add title argument to IconViewhelper

Oli Bartsch CR +2 V +2 Normal +71 −6 updated 12/01/23, 16:54

Commit message

Allow a title argument to be set in the IconViewHelper.
The give title will be passed to the `Icon` object and
will be rendered as title attribute in the icon HTML
markup, enhancing accessibility.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Oli Bartsch uploaded patch set 1 12/01/23, 16:40

  2. core-ci voted on patch set 1 V +1 12/01/23, 16:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50215

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 12/01/23, 16:54

  4. Oli Bartsch merged patch set 2 12/01/23, 16:54