Review main Merged Breaking

82066[!!!][TASK] Simplify adminPanel forceTemplateParsing

Christian Kuhn CR +2 V +2 Normal +59 −97 updated 12/03/23, 09:17

Commit message

EXT:adminpanel class TypoScriptWaterfall sets both
'no_cache' and the typoscript context aspect
'forcedTemplateParsing' to true when the admin
panel related option 'Force template parsing' is
enabled.

This setting is "on" by either using the admin panel
FE interface (which stores settings in BE user "uc"),
or using BE user UserTsConfig
admPanel.override.tsdebug.forceTemplateParsing = 1.

All consumers of the forcedTemplateParsing aspect
property (namely in TypoScriptFrontendController)
always check both 'no_cache' and 'forcedTemplateParsing',
so that's duplicate information.

The patch removes the 'typoscript' context aspect
altogether and simplifies consumers to rely on the
'no_cache' flag only.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 6