Review main Merged

82067[TASK] Update `phpstan/phpstan` to 1.10.47

Christian Kuhn CR +2 V +2 Easy +8 −8 updated 12/02/23, 11:12

Commit message

Also fix one unneeded null coalescing operator usage,
which was discovered with this release.

> composer require --dev phpstan/phpstan:^1.10.47

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1822

  1. Christian Kuhn uploaded patch set 1 12/02/23, 10:23

  2. core-ci voted on patch set 1 V +1 12/02/23, 10:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50235

  3. Benjamin Franzke commented on patch set 1 CR -1 12/02/23, 10:33

    Come, on, let's not pollute the baseline: Just change ``` $liveUid = ($row['t3ver_oid'] ?? null) ? ($row['t3ver_oid'] ?? null) : ($row['uid'] ?? null); ``` to: ``` $liveUid = ($row['t3ver_oid'] ?? null) ? $row['t3ver_oid'] : ($row['uid'] ?? null); ``` in typo3/sysext/core/Classes/DataHandling/DataHandler.php line 7653
  4. Oliver Klee voted on patch set 1 CR +1 V +1 12/02/23, 10:35

  5. Christian Kuhn uploaded patch set 2 CR +1 V +1 12/02/23, 10:37

  6. Benjamin Franzke uploaded patch set 3 12/02/23, 10:38

  7. Christian Kuhn uploaded patch set 4 CR +1 V +1 12/02/23, 10:38

  8. Christian Kuhn uploaded patch set 5 12/02/23, 10:40

  9. Benjamin Franzke commented on patch set 5 CR -1 12/02/23, 10:41

    patchset 5 is a change in behavior in case `t3ver_oid` is `0`. (it would not longer fallback to `$row['uid']`)
  10. Christian Kuhn commented on patch set 5 12/02/23, 10:42

    Reply

    true. much better now :)
  11. Christian Kuhn commented on patch set 5 12/02/23, 10:49

    Reply

    hmpf. true. good catch.
  12. Christian Kuhn uploaded patch set 6 CR -1 12/02/23, 10:50

  13. core-ci voted on patch set 5 V -1 12/02/23, 10:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50241

  14. Oliver Klee voted on patch set 6 CR +1 12/02/23, 10:54

  15. Christian Kuhn updated the commit message in patch set 7 CR +1 12/02/23, 10:55

  16. core-ci voted on patch set 6 V +1 12/02/23, 10:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50243

  17. Oliver Klee voted on patch set 7 CR +1 12/02/23, 10:58

  18. Benjamin Franzke voted on patch set 7 CR +1 V +1 12/02/23, 11:00

  19. core-ci voted on patch set 7 V +1 12/02/23, 11:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50245

  20. Oliver Klee voted on patch set 7 V +1 12/02/23, 11:07

  21. Christian Kuhn voted on patch set 7 CR +2 V +2 12/02/23, 11:12

  22. Christian Kuhn merged patch set 8 12/02/23, 11:12