82067[TASK] Update `phpstan/phpstan` to 1.10.47
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Benjamin Franzke +1
- Oliver Klee +1
-
Verified V +2 Done
- Christian Kuhn +2
- Benjamin Franzke +1
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1822
-
Christian Kuhn uploaded patch set 1 12/02/23, 10:23
-
core-ci voted on patch set 1 V +1 12/02/23, 10:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50235
-
Benjamin Franzke commented on patch set 1 CR -1 12/02/23, 10:33
Come, on, let's not pollute the baseline: Just change ``` $liveUid = ($row['t3ver_oid'] ?? null) ? ($row['t3ver_oid'] ?? null) : ($row['uid'] ?? null); ``` to: ``` $liveUid = ($row['t3ver_oid'] ?? null) ? $row['t3ver_oid'] : ($row['uid'] ?? null); ``` in typo3/sysext/core/Classes/DataHandling/DataHandler.php line 7653 -
Oliver Klee voted on patch set 1 CR +1 V +1 12/02/23, 10:35
-
Christian Kuhn uploaded patch set 2
CR +1V +112/02/23, 10:37 -
Benjamin Franzke uploaded patch set 3 12/02/23, 10:38
-
Christian Kuhn uploaded patch set 4
CR +1V +112/02/23, 10:38 -
Christian Kuhn uploaded patch set 5 12/02/23, 10:40
-
Benjamin Franzke commented on patch set 5 CR -1 12/02/23, 10:41
patchset 5 is a change in behavior in case `t3ver_oid` is `0`. (it would not longer fallback to `$row['uid']`) -
Christian Kuhn commented on patch set 5 12/02/23, 10:42
Reply
true. much better now :) -
Christian Kuhn commented on patch set 5 12/02/23, 10:49
Reply
hmpf. true. good catch. -
Christian Kuhn uploaded patch set 6
CR -112/02/23, 10:50 -
core-ci voted on patch set 5 V -1 12/02/23, 10:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50241
-
Oliver Klee voted on patch set 6 CR +1 12/02/23, 10:54
-
Christian Kuhn updated the commit message in patch set 7
CR +112/02/23, 10:55 -
core-ci voted on patch set 6 V +1 12/02/23, 10:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50243
-
Oliver Klee voted on patch set 7 CR +1 12/02/23, 10:58
-
Benjamin Franzke voted on patch set 7 CR +1 V +1 12/02/23, 11:00
-
core-ci voted on patch set 7 V +1 12/02/23, 11:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50245
-
Oliver Klee voted on patch set 7 V +1 12/02/23, 11:07
-
Christian Kuhn voted on patch set 7 CR +2 V +2 12/02/23, 11:12
-
Christian Kuhn merged patch set 8 12/02/23, 11:12