Review 12.4 Merged

82068[TASK] Update `phpstan/phpstan` to 1.10.47

Christian Kuhn CR +2 V +2 Easy +8 −8 updated 12/02/23, 11:12

Commit message

Also fix one unneeded null coalescing operator usage,
which was discovered with this release.

> composer require --dev phpstan/phpstan:^1.10.47

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1115

  1. Christian Kuhn uploaded patch set 1 12/02/23, 10:29

  2. Benjamin Franzke voted on patch set 1 CR -1 12/02/23, 10:33

  3. core-ci voted on patch set 1 V +1 12/02/23, 10:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50237

  4. Oliver Klee voted on patch set 1 CR +1 12/02/23, 10:35

  5. Christian Kuhn uploaded patch set 2 CR +1 V +1 12/02/23, 10:41

  6. core-ci voted on patch set 2 V -1 12/02/23, 10:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50242

  7. Christian Kuhn uploaded patch set 3 V -1 12/02/23, 10:51

  8. Oliver Klee voted on patch set 3 CR +1 12/02/23, 10:55

  9. Christian Kuhn updated the commit message in patch set 4 CR +1 12/02/23, 10:56

  10. core-ci voted on patch set 3 V +1 12/02/23, 10:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50244

  11. Oliver Klee voted on patch set 4 CR +1 12/02/23, 10:58

  12. core-ci voted on patch set 4 V +1 12/02/23, 11:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50246

  13. Oliver Klee voted on patch set 4 V +1 12/02/23, 11:03

  14. Christian Kuhn voted on patch set 4 CR +2 V +2 12/02/23, 11:12

  15. Christian Kuhn merged patch set 5 12/02/23, 11:12