Review main Merged Breaking

82074[!!!][TASK] Remove TSFE->no_cacheBeforePageGen "safety net"

Christian Kuhn CR +2 V +2 Normal +51 −30 updated 12/03/23, 15:14

Commit message

TypoScriptFrontendController->no_cacheBeforePageGen is a flag
used by generatePage_preProcessing() to ensure an extension
never sets no_cache=false when it has been set to true before
since this would lead to broken cache handling: FE Caching
must never be enabled again after it has been disabled once.

Upcoming patches model the cache information differently and
will no longer allow re-enabling caching when it has been
enabled once - at least if an extension does not do very
hacky request manipulations.

The patch removes this "safety net" since it collides with
upcoming changes.

Method and property are internal handling, but the method
has unfortunately never been set @internal, which is why
this patch is marked as breaking.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 710

  1. Christian Kuhn uploaded patch set 1 12/03/23, 10:41

  2. Christian Kuhn updated the commit message in patch set 2 12/03/23, 10:42

  3. core-ci voted on patch set 1 V +1 12/03/23, 10:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50271

  4. core-ci voted on patch set 2 V +1 12/03/23, 10:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50272

  5. Christian Kuhn uploaded patch set 3 12/03/23, 11:27

    Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  6. core-ci voted on patch set 3 V +1 12/03/23, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50273

  7. Stefan Bürk voted on patch set 3 CR +1 V +1 12/03/23, 12:34

  8. Oliver Klee voted on patch set 3 CR +1 V +1 12/03/23, 14:35

  9. Stefan Bürk voted on patch set 3 CR +2 V +2 12/03/23, 15:14

  10. Stefan Bürk merged patch set 4 12/03/23, 15:14