Review main Merged

82077[TASK] Use platform `instanceof` checks in `ConnectionMigrator`

Stefan Bürk CR +2 V +2 Easy +20 −17 updated 12/06/23, 09:31

Commit message

The TYPO3 ConnectionMigrator implementation used to retrieve
a string representation for a platform, originally based on
the deprecated `AbstractPlatform->getName()` method.

The `getDatabasePlatformName()` method has been streamlined
to return the string representation based on the platform.

This change modifies the method now to return the platform
instance instead of a string representation. For unsupported
platforms a `\RuntimeException` is now thrown. Corresponding
user land code checking for the platform is modified to use
`instanceof` checks instead of string checks now.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 912

  1. Stefan Bürk uploaded patch set 1 12/03/23, 15:56

  2. Stefan Bürk wrote 12/03/23, 15:57

    Topic set to doctrine-dbal
  3. core-ci voted on patch set 1 V +1 12/03/23, 16:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50283

  4. Stefan Bürk uploaded patch set 2 V +1 12/03/23, 16:13

  5. core-ci voted on patch set 2 V +1 12/03/23, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50284

  6. Oliver Klee voted on patch set 2 CR +1 V +1 12/03/23, 16:27

  7. Stefan Bürk commented on patch set 2 CR -1 12/03/23, 21:23

    relation chain -> temp -1 for now
  8. Christian Kuhn rebased onto patch set 3 CR +1 V +1 12/06/23, 09:21

  9. Christian Kuhn voted on patch set 3 CR +1 V +1 12/06/23, 09:21

  10. core-ci voted on patch set 3 V +1 12/06/23, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50404

  11. Benni Mack voted on patch set 3 CR +2 V +2 12/06/23, 09:31

  12. Benni Mack merged patch set 4 12/06/23, 09:31