Review main Abandoned

82084[TASK] Clean up `ResourceView`

Oli Bartsch CR 0 V 0 Hard +134 −123 updated 12/08/23, 13:59

Commit message

This applies some code clean up to the `ResourceView`,
used in the filelist module. Thereby, a new enum
`ResourceType` is introduced.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 5

Review log 57

  1. Oli Bartsch uploaded patch set 1 12/04/23, 17:02

  2. core-ci voted on patch set 1 V +1 12/04/23, 17:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50332

  3. Oli Bartsch commented on patch set 2 V +1 12/05/23, 07:56

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V +1 12/05/23, 08:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50350

  5. Jochen Roth voted on patch set 2 CR +1 V +1 12/06/23, 10:26

  6. Christian Kuhn commented on patch set 2 CR -1 12/08/23, 13:59

    This does not make sense from an architectural point of view. This introduces an enum that "api's away" an inheritance structure. It is an abstraction of inheritance. This does not make sense to me and leads to issues like phpstan being not happy at this point. Talked with Oli about this - we'll abandon her.
  7. Christian Kuhn abandoned the change 12/08/23, 13:59