Review main Merged Breaking

82085[!!!][TASK] Avoid TSFE->applicationData

Christian Kuhn CR +2 V +2 Normal +119 −11 updated 12/04/23, 19:21

Commit message

Property applicationData of TypoScriptFrontendController
is unfortunate: It is meant as an extension place to park
and communicate state using the just so convenient global
$GLOBALS['TSFE'] object.

Such things should of course be modeled differently, for
instance by adding own PSR-7 request attributes using a
custom middleware, or by firing own events for other
extensions to listen on.

In order to continue with our works on TSFE, the patch
removes that property.

The single use of that property in is ext:indexed_search:
It is used in combination with the crawler extension to
"force indexing". indexed_search now dispatches a proper
event instead.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 68

  1. Christian Kuhn uploaded patch set 1 12/04/23, 17:14

  2. Christian Kuhn updated the commit message in patch set 2 12/04/23, 17:18

  3. core-ci voted on patch set 1 V +1 12/04/23, 17:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50334

  4. core-ci voted on patch set 2 V +1 12/04/23, 17:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50335

  5. Benni Mack voted on patch set 2 CR +1 V +1 12/04/23, 18:12

  6. Stefan Bürk voted on patch set 2 CR +1 V +1 12/04/23, 18:29

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 12/04/23, 19:21

  8. Christian Kuhn merged patch set 3 12/04/23, 19:21