Review main Merged

82115Revert "[BUGFIX] Set HTTP timeout to 20 seconds"

Oliver Hader CR +2 V +2 Easy +1 −1 updated 12/07/23, 10:17

Commit message

This reverts commit f49f871bff426c2913b65eebcc087cf37769fd08.

The change for issue #102606 has the potential to do more harm
than good. The initial intention was to define a HTTP timeout to
be lower than the PHP `max_execution_time`. Defining general
HTTP `timeout` of 20 seconds now also limits e.g. long running
CLI processes - which can be considered a breaking change.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Oliver Hader uploaded patch set 1 12/06/23, 21:17

  2. Oliver Hader updated the commit message in patch set 2 12/06/23, 21:18

  3. Stefan Bürk voted on patch set 2 CR +1 V +1 12/06/23, 21:19

  4. core-ci voted on patch set 1 V +1 12/06/23, 21:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50430

  5. core-ci voted on patch set 2 V +1 12/06/23, 21:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50431

  6. Christian Kuhn voted on patch set 2 CR +1 12/07/23, 06:52

  7. Benni Mack commented on patch set 2 CR +2 V +2 12/07/23, 07:29

    Thanks for handling the revert
  8. Oliver Hader merged patch set 3 12/07/23, 10:17