Review 12.4 Merged

82116[BUGFIX] Fix GeneralUtility::validEmail() with spaces in email

Oli Bartsch CR +2 V +2 Normal +67 −1 updated 12/07/23, 10:05

Commit message

`GeneralUtility::validEmail()` uses the package egulias/email-validator
for validating emails. It treats the email `test @testmail.com` as
valid, but triggers a warning that is not caught, since the syntax has
only been marked as deprecated by egulias/email-validator.

A check for warnings of the type CFWSNearAt will now be performed, which
results in the email `test @testmail.com` being marked as invalid.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Oli Bartsch commented on patch set 1 12/07/23, 09:57

    Cherry Picked from branch main.
  2. Oli Bartsch voted on patch set 1 CR +2 V +2 12/07/23, 09:57

  3. core-ci voted on patch set 1 V +1 12/07/23, 10:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50440

  4. Oli Bartsch merged patch set 2 12/07/23, 10:05