Review main Abandoned

82135[BUGFIX] Reduce timeout of guzzle HTTP requests

Stefan Froemken CR 0 V 0 Easy +13 −1 updated 01/10/24, 09:55

Commit message

TYPO3 comes with a TYPO3_CONF_VARS/HTTP/timeout which
defaults to 0 seconds (infinite). This value equals the
default of the guzzle client itself. This default
is perfect for CLI usage, but in web environment we
have to taken max_execution_time into account. As
there are very different max_execution_time values out
there, TYPO3 will set HTTP/timeout to 80% of your
configured max_execution_timeout value.
If you have configured max_execution_time to 0, TYPO3
will also keep 0 for HTTP/timeout. If you have configured
HTTP/timeout on your own, TYPO3 will not modify that
value.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 67

  1. Stefan Froemken uploaded patch set 1 12/06/23, 13:51

  2. core-ci voted on patch set 1 V +1 12/06/23, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50423

  3. Oliver Hader commented on patch set 1 12/06/23, 14:16

    CLI might have `max_execution_time` as well, just try: ``` php --run "var_dump(password_hash('password', PASSWORD_ARGON2I, ['time_cost' => PASSWORD_ARGON2_DEFAULT_TIME_COST * 1024]));" -dmax_execution_time=1 Fatal error: Maximum execution time of 1+2 seconds exceeded (terminated) in Command line code on line 1 ``` All of these scenarios are individual and are difficult to be solved "automatically". That's why there are settings for adjusting them accordingly.
  4. Oliver Hader commented on patch set 1 12/06/23, 14:18

    Instead of making this more complicated than necessary, I'd be in favor of reverting the previous change - see https://forge.typo3.org/issues/102610
  5. Oliver Hader voted on patch set 1 CR -1 12/06/23, 21:19

  6. Oliver Hader commented on patch set 1 01/10/24, 09:54

    The previous change has been revered with https://review.typo3.org/c/Packages/TYPO3.CMS/+/82115 I'm closing this change-set as well.
  7. Oliver Hader abandoned the change 01/10/24, 09:55