Review main Merged

82139[TASK] Add strict parameter to base64url decode

Oliver Hader CR +2 V +2 Easy +31 −4 updated 12/22/23, 11:34

Commit message

PHP's base64_decode has a strict parameter to only
accept characters of the corresponding base64 alphabet,
see https://www.php.net/manual/en/function.base64-decode.php

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 89

  1. Oliver Hader uploaded patch set 1 12/06/23, 22:12

  2. core-ci voted on patch set 1 V +1 12/06/23, 22:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50432

  3. Oli Bartsch voted on patch set 1 CR +1 V +1 12/07/23, 08:47

  4. Christian Kuhn voted on patch set 1 CR +1 V +1 12/07/23, 12:35

  5. Oliver Klee voted on patch set 1 CR +1 V +1 12/07/23, 12:41

  6. Jörg Bösche voted on patch set 1 CR +1 12/15/23, 10:20

  7. Stefan Bürk voted on patch set 1 CR +1 V +1 12/21/23, 22:51

  8. Oliver Hader voted on patch set 1 CR +2 V +2 12/22/23, 11:34

  9. Oliver Hader merged patch set 2 12/22/23, 11:34