Review main Merged

82147[BUGFIX] Use _LOCALIZED_UID also for pages in Extbase persistence

Benni Mack CR +2 V +2 Easy +5 −0 updated 12/08/23, 09:50

Commit message

When pages use overlays, the special key "_PAGES_OVERLAY_UID"
is used (PageRepository->getPageOverlay), for other
pages doing overlays, the property "_LOCALIZED_UID" is used
(PageRepository->getRecordOverlay).

Extbase is setting the special property $_localizedUid in
a Domain Model, based on the key "_LOCALIZED_UID" in the
DataMapper. The Typo3DbBackend now maps the _PAGES_OVERLAY_UID
onto the _LOCALIZED_UID in order to have Extbase deal with
language overlays in pages as well.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Benni Mack uploaded patch set 1 12/07/23, 14:20

  2. core-ci voted on patch set 1 V +1 12/07/23, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50456

  3. Anja Leichsenring voted on patch set 1 CR +1 V +1 12/08/23, 07:50

  4. Oli Bartsch voted on patch set 1 CR +1 V +1 12/08/23, 08:03

  5. Benni Mack voted on patch set 1 CR +2 V +2 12/08/23, 09:50

  6. Benni Mack merged patch set 2 12/08/23, 09:50