Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
82150[TASK] Convert fieldset legend to label for toggle checkboxes
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 11
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/50/82150/11 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/50/82150/11 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V -1 Blocked
- core-ci -1 CI
Issues 1
Files 3
Review log 2536
Show 811 earlier messages
-
Willi Wehmeier uploaded patch set 1 12/08/23, 10:08
-
core-ci voted on patch set 1 V -1 12/08/23, 10:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50483
-
Willi Wehmeier uploaded patch set 2
V -112/08/23, 10:21 -
Willi Wehmeier wrote 12/08/23, 10:22
Removed cc Oli Bartsch. -
core-ci voted on patch set 2 V +1 12/08/23, 10:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50484
-
Torben Hansen commented on patch set 2 V -1 12/09/23, 06:43
Although the change may improve the accessibility of the `checkboxToggle` element, it also leads to duplication of labels. As an example, the "Page visible" checkbox now has the same text twice - one time for the fieldset `legend` and one time for the checkbox `label`. This may lead to reduced user experience in the backend and also screenreaders will read the fieldset legend and the checkbox label. The `checkboxToggle` element can have one or multiple items. In case it has one item, the checkbox is most likely described by the fieldset `legend`. In case it has multiple items, the fieldset legend describes the grouped checkbox fields and the checkbox labels the individual functionality/value of the checkbox. So IMO, adding labels to all checkbox items as suggested in this patch is not suitable. Instead, we could improve this area by e.g. using `aria-label` or `aria-labeledby` for checkboxes with only one item and where the fieldset legend already describes the functionality/value of the checkbox. I CCed Michael Telgkamp on this issue. Maybe he can also provide some feedback/ideas on how we can improve accessibility for the `checkboxToggle` elements without visible duplication of labels. -
Torben Hansen commented on patch set 2 12/09/23, 08:00
In addition: Maybe we could change the output of the checkbox with rendertype `checkboxToggle`, so the resulting HTML does not contain a fieldset, if there is only one checkbox item that does not have any label in TCA. Instead we could render the current fieldset legend as label and the checkbox as is. -
Willi Wehmeier uploaded patch set 3
V +112/19/23, 08:15 -
Willi Wehmeier commented on patch set 3 12/19/23, 08:17
Reply
I've pushed another approach which replaces the fieldset legend with a label when there's only one available option without a configured label. I think this is a practicable tradeoff. -
core-ci voted on patch set 3 V -1 12/19/23, 08:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50789
-
Willi Wehmeier uploaded patch set 4
V -112/19/23, 08:22
-
core-ci voted on patch set 4 V +1 12/19/23, 08:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50790
-
Christian Kuhn commented on patch set 4 CR -1 12/19/23, 13:48
CheckboxToggleElement.php:66I'm not a fan of this property. Could we refactor it out somehow and hand it over or calculate differently? It also seems only [0] is used in practice. -
Willi Wehmeier commented on patch set 4 12/19/23, 14:08
CheckboxToggleElement.php:66ReplyWould be possible. I already thought about that. But that approach would change the signature of the protected renderSingleCheckboxElement() method. If that's not an issue, I will move the generation of the identifier out of that method and hand it over. -
Willi Wehmeier uploaded patch set 5
CR -1V +112/20/23, 06:33 -
core-ci voted on patch set 5 V +1 12/20/23, 06:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50833
-
Willi Wehmeier commented on patch set 5 12/20/23, 07:21
CheckboxToggleElement.php:66ReplyI just pushed a new changeset without the intermediate array property. 😊 -
Torben Hansen commented on patch set 5 01/05/24, 10:45
Reply
DoneCheckboxToggleElement.php:150All Form Elements return the `$resultArray` at the end of the function and I think we should keep it that way. So please use if/else for the `'html'` assignment here and return `$resultArray` at the end of the function. -
Christian Rath-Ulrich uploaded patch set 6
V +102/07/24, 10:36 -
Christian Rath-Ulrich commented on patch set 6 02/07/24, 10:39
I have reset this part to the original because there is a conflict with https://review.typo3.org/c/Packages/TYPO3.CMS/+/82723 and the solution there includes the old debug mechanism -
core-ci voted on patch set 6 V -1 02/07/24, 10:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52845
-
Christian Rath-Ulrich uploaded patch set 7 02/12/24, 11:15
Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 7 V -1 02/12/24, 11:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53077
-
Christian Rath-Ulrich uploaded patch set 8
V -102/12/24, 11:21 -
core-ci voted on patch set 8 V +1 02/12/24, 11:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53078
-
Willi Wehmeier uploaded patch set 9
V +103/12/24, 07:52 -
core-ci voted on patch set 9 V -1 03/12/24, 07:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54395
-
Willi Wehmeier uploaded patch set 10
V -103/12/24, 08:02 -
core-ci voted on patch set 10 V +1 03/12/24, 08:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54396
-
Willi Wehmeier commented on patch set 10 03/12/24, 08:16
CheckboxToggleElement.php:150ReplyDone 😊 -
Benjamin Franzke commented on patch set 10 05/03/24, 08:33
Can we add the needed/proper labels to all elements in order to avoid applying implicit heuristics to label-generation? -
Willi Wehmeier commented on patch set 10 05/03/24, 10:13
Reply Unresolved
@ben@bnf.dev In my first patchset I've tried to add proper labels to all missing places in the core TCA. That approach caused duplicate text read-out by screenreaders when the fieldset legend is the same as the label of the checkboxToggle itself. I'd really prefer to add proper labels to all toggles instead of the current approach but I'm not sure if we'll find proper label/legend text combinations which are explanatory enough without doubling. See: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82150/comments/e4f0bc17_213dc285 -
Benni Mack updated the commit message in patch set 11
V +110/18/24, 13:30 -
core-ci voted on patch set 11 V -1 10/18/24, 21:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67976
-
Benni Mack marked it work in progress 02/25/25, 15:25
-
Benni Mack commented on patch set 11 02/25/25, 15:25
any progress here?