Review main Merged

82153[BUGFIX] Remove unnecessary BackendUtility::getProcessedValue() call in GridColumn

Oli Bartsch CR +2 V +2 Easy +2 −2 updated 12/09/23, 12:47

Commit message

Using BackendUtility::getProcessedValue() in GridColumn to
fetch a backend layout column's title is unnecessary and also
leads to an undefined array key warning. The call is therefore
removed. The information is always fetched using the resolved
BackendLayout object. Cases like unassigned columns are handled
at other places already.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Torben Hansen +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Torben Hansen +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Oli Bartsch uploaded patch set 1 12/08/23, 16:12

  2. core-ci voted on patch set 1 V +1 12/08/23, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50511

  3. Jochen Roth voted on patch set 1 CR +1 V +1 12/08/23, 16:20

  4. Torben Hansen voted on patch set 1 CR +1 V +1 12/09/23, 06:00

  5. Christian Kuhn voted on patch set 1 CR +1 V +1 12/09/23, 10:51

  6. Oli Bartsch voted on patch set 1 CR +2 V +2 12/09/23, 11:26

  7. Oli Bartsch merged patch set 2 12/09/23, 12:47