Review main Merged

82156[TASK] Update `phpstan/phpstan:^1.10.48`

Christian Kuhn CR +2 V +2 Easy +13 −8 updated 12/09/23, 11:32

Commit message

New phpstan find a fishy but not trivial to resolve
inheritance return type definition. Add to baseline
for now.

> composer req --dev phpstan/phpstan:^1.10.48
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 45

  1. Christian Kuhn uploaded patch set 1 12/09/23, 11:05

  2. core-ci voted on patch set 1 V +1 12/09/23, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50520

  3. Oliver Klee voted on patch set 1 CR +1 V +1 12/09/23, 11:16

  4. Christian Kuhn voted on patch set 1 CR +2 V +2 12/09/23, 11:32

  5. Christian Kuhn merged patch set 2 12/09/23, 11:32