Review main Merged

82158[TASK] Avoid TSFE->getContext() and TSFE->getRequestedId()

Christian Kuhn CR +2 V +2 Normal +78 −160 updated 12/09/23, 18:25

Commit message

The context object is injectable singleton state - "Not good
but not terrible". There is no need to have a getter in
TypoScriptFrontendController for it. Refactor this. A test
case mocking can be simplified significantly with this.

The "originally requested id" can be retrieved from
the 'routing' Request attribute, there is not need to
carry a copy as TSFE property around.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 15