Review main Merged

82160[DOCS] Fix sphinx warnings in the Changelog

Lina Wolf CR +2 V +2 Easy +7 −11 updated 08/01/24, 21:10

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Chris Müller +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Chris Müller +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1114

  1. Lina Wolf uploaded patch set 1 12/09/23, 20:10

  2. Lina Wolf uploaded patch set 2 12/09/23, 20:12

  3. core-ci voted on patch set 1 V +1 12/09/23, 20:15 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 2 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50534

  4. core-ci voted on patch set 2 V +1 12/09/23, 20:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50535

  5. Chris Müller commented on patch set 2 CR -1 12/09/23, 20:41

    Important-102314-TitleCoreIconViewhelper.rst:30

    Looks like a tab ... should be 4 spaces.
  6. Lina Wolf uploaded patch set 3 CR -1 V +1 12/09/23, 20:48

  7. Lina Wolf commented on patch set 3 12/09/23, 20:48

    Important-102314-TitleCoreIconViewhelper.rst:30 Reply

    Done
  8. core-ci voted on patch set 3 V +1 12/09/23, 20:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50537

  9. Chris Müller voted on patch set 3 CR +1 V +1 12/10/23, 00:42

  10. Christian Kuhn voted on patch set 3 CR +2 V +2 12/10/23, 07:31

  11. Christian Kuhn merged patch set 4 12/10/23, 07:32

  12. Stephan Großberndt commented on patch set 4 12/10/23, 09:57

    due to the changes in v12 changelogs - doesn't this need a backport to the 12 branch as well?
  13. Chris Müller commented on patch set 4 12/10/23, 14:01

    Reply

    No content changed, and as the changelogs are not rendered on docs.typo3.org for 12.4 this is not really necessary IMHO.
  14. Stephan Großberndt commented on patch set 4 12/11/23, 08:39

    Reply

    Thanks, that makes sense!